search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
991 stars 356 forks source link

Web interface - Simple desk page number non-integer value #1576

Closed yestalgia closed 3 months ago

yestalgia commented 4 months ago

Describe the bug There is a bug with the previousPage() function which causes the decimal places ".53333333333333" to appear with the Page Number.

I couldn't find a reference to this issue on the forum or GitHub.

image

image

To Reproduce Steps to reproduce the behavior:

  1. Run QLC+ with the -w flag Web Interface Docs
  2. Using Chrome, navigage to http://127.0.0.1:9999/simpleDesk
  3. Shrink the window
  4. Hit refresh the page
  5. Click the back arrow next to the page indicator
  6. The page indicator will put the page number and a bunch of decimal places of garbage.

Expected behavior Single integer values to appear, such as when using the nextPage() button. Screenshots If applicable, add screenshots to help explain your problem.

Desktop:

Additional context I believe the problem is with simpledesk.js within this function: image

yestalgia commented 4 months ago

Additionally, it seems you can keep pressing the back button into negative values:

image

This crashes the program.

mcallegari commented 4 months ago

Do you have a custom number of faders set for Simple desk?

Note to myself: this is the referenced line of code https://github.com/mcallegari/qlcplus/blob/master/webaccess/res/simpledesk.js#L127

yestalgia commented 4 months ago

Do you have a custom number of faders set for Simple desk?

Note to myself: this is the referenced line of code https://github.com/mcallegari/qlcplus/blob/master/webaccess/res/simpledesk.js#L127

No only standard

yestalgia commented 3 months ago

After playing around with the latest release, either the bug isn't present anymore or it is impossible to replicate.

Closing to declutter the issues tab. If I find it occurs again I'll reopen.