search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
918 stars 349 forks source link

Highlight Fixtures feature #1577

Open Timebutt opened 1 month ago

Timebutt commented 1 month ago

@yestalgia this is the updated branch for the Highlight Fixtures feature you can test ;)

coveralls commented 1 month ago

Coverage Status

coverage: 31.949% (-0.06%) from 32.007% when pulling 6126f7cdca75a10ed2538d101f5316d8d4d5913f on Timebutt:add-fixture-tester-feature-2 into ff16fdc696ba235374bd544731f04649c7e53087 on mcallegari:master.

mcallegari commented 3 weeks ago

As I mentioned before, please remove SVG files.

yestalgia commented 1 week ago

Hey guys,

I've done some testing and want to share what I've discovered.

Firstly, I appreciate the direction this feature is going in. However, I've found the following bugs:

  1. Especially when clicking between the different UI Tabs (Fixtures - Functions - Shows etc), I find that the behaviour of the highlight is inconsitent. Here's some steps to reproduce:

    • Open HighlightTest.qxw
    • Open the Simple Desk in a new window (double click the tab). Notice the first fixture's channels (1,2,3,4) are down. Sick.
    • Go back to fixtures tab
    • Click the generic RGB fixture
    • Click highlight
    • It does not work

  2. After testing scenario 1, click the "Universe 1: Highlight" universe group.

    • Notice the par is highlighted but the Aura isnt. Why?

What should the highlight do when clicking groups created by the user or the universes? I believe it should be either do nothing or highlight all the fixtures in that group.

Thanks for reading my bug report, hope we can get something into master eventually.