mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
911 stars 349 forks source link

Open TX/RX support for generic USB CDC devices #1583

Open caitlynrw opened 3 weeks ago

caitlynrw commented 3 weeks ago

Describe the bug The Open TX/RX driver doesn't support non-FTDI serial ports.

To Reproduce Steps to reproduce the behavior:

  1. Connect a non-FTDI serial adapter, I've tested a MCP2200 and CH340
  2. Observe in Device Manager or UsbTreeView that the device is recognized as a serial port
  3. Open QLC+ and navigate to the Inputs/Outputs pane and see no USB DMX is available

Expected behavior Open TX/RX drivers can be used with other USB UART bridges.

Screenshots Connecting an Enttec Open DMX dongle Screenshot 2024-06-10 205456 Connecting an MCP220 or CH340 UART converter Screenshot 2024-06-10 205507

Desktop (please complete the following information):

Additional context N/A

mcallegari commented 3 weeks ago

Not every serial port in the world can be used as a DMX transmitter. FTDI is known to be a good solution to DMX. To add more chipsets I need to qualify them so basically I need to physically own them. Unless you prove they can be used as DMX adapter with the proper timings and without side effects.

In the meantime you can build QLC+ from sources and adapt this method to test other chipsets https://github.com/mcallegari/qlcplus/blob/master/plugins/dmxusb/src/dmxinterface.cpp#L73

If you can't do any of the above, I'll ned to close this ticket.

yestalgia commented 3 weeks ago

@caitlynrw if you make a PR I'd be willing to buy devices to test