mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
918 stars 349 forks source link

OSC Channel Number Calculator off by one #1585

Closed qfulmina closed 3 weeks ago

qfulmina commented 3 weeks ago

Describe the bug The OSC Channel Number Calculator at the OSC Plugin configuration appears to be off by one.

To Reproduce Go to Input/Output. Choose OSC Plugin. Input /qlc/test to the Channel Number Calculator. You get 46808 as the Channel number. Create a Widget e.g. a Button in the Virtual Console. Edit the properties and Auto detect External Input. Send a test value to /qlc/test and you get 46809. E.g. with this python script

from pythonosc import udp_client

client = udp_client.SimpleUDPClient('127.0.0.1', 7700)

client.send_message("/qlc/test", 0.5)

This happens to all OSC paths.

Expected behavior Same Channel Numbers.

Screenshots OSC Channel Number Calculator at the OSC Plugin configuration Detected Channel Number

Desktop (please complete the following information):

mcallegari commented 3 weeks ago

I think there is a misunderstanding here. What you see in the input profile editor is channel + 1 but what is written in the profile is channel. Check for example this https://github.com/mcallegari/qlcplus/blob/master/resources/inputprofiles/TouchOSC-Automat5.qxi#L62 is presented as this

Screenshot_20240616_211130

So the calculator is correct, since it outputs what you actually need to write in an input profile or your custom OSC node. Closing.

qfulmina commented 3 weeks ago

Thanks for clarifying, @mcallegari

I think there is a misunderstanding here.

True. And sorry for that.

What you see in the input profile editor is channel + 1 but what is written in the profile is channel. Check for example this https://github.com/mcallegari/qlcplus/blob/master/resources/inputprofiles/TouchOSC-Automat5.qxi#L62 is presented as this

Alright. Could we place a hint somewhere near the calculator? Tooltip, text, some kind of question mark icon, or the like?

I might not be the only one wondering that there is a difference and having a hard time remembering if and where to add 1 (or subtract?) when setting up the VC with channels calculated by the calculator.

mcallegari commented 3 weeks ago

Documentation updated https://docs.qlcplus.org/v4/plugins/osc