search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
954 stars 354 forks source link

Cuelist with Submaster doesn't work until QLC+ is reloaded #1595

Open CarnivalBen opened 2 months ago

CarnivalBen commented 2 months ago

Describe the bug If you set up the virtual console with a cuelist and a submaster inside a solo frame, the submaster does not work until the workspace is saved, QLC+ is restarted and the workspace re-loaded.

To Reproduce Steps to reproduce the behavior:

  1. Open QLC+
  2. Add a generic dimmer fixture.
  3. Add a scene that sets the test fixture to 100%.
  4. Add a chaser that contains the new scene with hold/duration set to infinite.
  5. Switch to Virtual Console.
  6. Add a Solo Frame.
  7. Add a Cuelist inside the solo frame, in the properties set the cuelist chaser to the one created in step 4, and set the side fader to crossfade.
  8. Add a slider inside the same solo frame, in the properties switch to submaster mode.
  9. Open the fixture monitor.
  10. Switch to operate mode.
  11. Click Play on the cuelist, note the fixture monitor shows the fixture at max brightness.
  12. Adjust the submaster slider - The fixture brightness does not change as it should.
  13. Save the workspace.
  14. Close, reopen QLC+ and the saved workspace.
  15. Perfom steps 9 to 12 again... this time the fixture brightness is affected by the submaster, as you'd expect.

Expected behavior I would expect the submaster to work without having to reload the workspace.

Desktop (please complete the following information):

CarnivalBen commented 2 months ago

Also tested it with QLC+ v4.13.1 - Issue remains.

mcallegari commented 2 months ago

Not reproduced. Submaster worked immediately without reloading the project

CarnivalBen commented 2 months ago

I just tried it again and followed my own reproduction steps, and it worked for me as well... but this might have been a difference between 4.13.0 and 4.13.1 as I only did a quick test after I upgraded and maybe I did something slightly differently.

However, there is still a problem in v4.13.1. I have created a video of me reproducing it, so you can see exactly what I'm doing:

https://youtu.be/r76tMpBkU5g

To reproduce, follow the same steps as the original issue - but this time, do this:

  1. Edit the submaster slider properties, and set it to Playback mode.
  2. Immediately edit the submaster slider properties again, and set it back to Submaster mode.
  3. Switch to Operate mode.
  4. Click play on the cuelist, and test the submaster slider to see if it changes the brightness of the fixture.

Hope that helps :)