search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
1.02k stars 360 forks source link

qmltoqt6 rebase + ui fix #1607

Closed Ledjlale closed 2 months ago

Ledjlale commented 2 months ago

Rebase qmltoqt6 from master. + Add a compile option to build for QLC5 (cmake) Remove qml slot depreciation. Adapt disclaimer text size to content.

mcallegari commented 2 months ago

Hey, sorry but this is not the proper way to contribute. I won't even start to review a PR with 408 changed files. Can we please first discuss this in the forum software development area?

As far as I can see there are commits with a mix of changes with a misleading title, code style changes, UI fixes, etc. I need to know exactly the goal of this PR and the areas you modified. Most likely this has to be split in 3-4 separated PRs.

Thanks

Ledjlale commented 2 months ago

Hi, all but the last commits come from the rebase (git rebase origin/master)

The only one I personally added is the last and cover what the PR describe.