cmake: Make hotplugmonitor a static lib

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.

Apache License 2.0

1.02k stars 360 forks source link

cmake: Make hotplugmonitor a static lib #1616

Closed kiilerix closed 1 month ago

kiilerix commented 2 months ago

hotplugmonitor is not hooked up to be installed as dynamic library, and hotplugmonitor/src/src.pro declares it as staticlib . It seems like it was the intent that the cmake build system should do the same.

coveralls commented 2 months ago

coverage: 31.993% (+0.002%) from 31.991% when pulling 5fb8842b3d8221b24651eddbf1de15490ef78770 on kiilerix:static-hotplug into 3c71bbbfcc7ad553bec33605054f613718e2c7c5 on mcallegari:master.

mcallegari commented 1 month ago

Indeed, thanks for this :+1: