search

mcallegari / qlcplus

Q Light Controller Plus (QLC+) is a free and cross-platform software to control DMX or analog lighting systems like moving heads, dimmers, scanners etc. This project is a fork of the great QLC project written by Heikki Junnila that aims to continue the QLC development and to introduce new features.
Apache License 2.0
1.02k stars 360 forks source link

Stagecolor fixes #1632

Closed hjtappe closed 3 weeks ago

hjtappe commented 1 month ago

Some fixes to the stagecolors branch as discussed in commit https://github.com/mcallegari/qlcplus/commit/6cd67bd387a727d47ff74c4fdb11904727d42bda#diff-7836f394b259eeac1462b437b8f6cc7774694630be49d08e2468ba2a3cf17f3eR143

Update of balls.js still and merge of marquee and alternate still pending.

coveralls commented 1 month ago

Coverage Status

coverage: 31.61%. remained the same when pulling 90d14b0124d7e72a4d2c9bac209e150e8489294c on hjtappe:stagecolor-fixes into 7a521454f387268b66a80b773c5b228f891b4ba4 on mcallegari:stagecolors.

hjtappe commented 4 weeks ago

I have merged the three balls* scripts now into just the balls.js. Please review. What's missing is the modification around RGBAlgorithmColorDisplayCount which should become v4 ui/ code specific, but that could be another PR - or it is fixed with your efforts to update the QML ui code.

mcallegari commented 3 weeks ago

Merged, thanks I'll update the QML UI too