mcanouil / eggla

Early Growth Genetics Longitudinal Analysis.
https://m.canouil.dev/eggla/
Other
2 stars 1 forks source link

Inconsistent use of vep and vep_file in run_eggla_gwas() #101

Closed burrowsk closed 1 year ago

burrowsk commented 1 year ago

Bug description

The parameter to add the path to a VEP annotation file is vep within run_eggla_gwas() [line 95]. the parameter vep is called in line 443 vep_file = vep, however, all other instances specify vep_file which causes the function to exit upon the first instance [lines 408-423]. Only applicable should a user want to specify a vep file.

if (nzchar(system.file(package = "future.apply"))) {
    eggla_lapply <- function(X, basename_file, vep_file, bin_path, bcftools_view_options, build, strand, info_type, FUN) {
      future.apply::future_lapply(
        X = X,
        basename_file = basename_file,
        vep_file = vep_file,
        bin_path = bin_path,
        bcftools_view_options = bcftools_view_options,
        build = build,
        strand = strand,
        info_type = info_type,
        future.globals = FALSE,
        future.packages = "data.table",
        FUN = FUN
      )
    }

eggla version output

eggla 0.18.5

Checklist

mcanouil commented 1 year ago

This is normal, "vep_file" is internal when defined eggla_lapply. Although I simplified this and anyway renamed the main argument to be more consistent with syntax of other arguments.

I believe the issue you are having is somewhere else, i.e., https://github.com/mcanouil/eggla/blob/1eb2dd56b4c0f883493f99e8d186425361ca4ffd/R/run_eggla_gwas.R#L449-L480

Note that the changes are in the current PR #97