search

mcarleio / konvert

This kotlin compiler plugin is using KSP API and generates kotlin code to map one class to another
https://mcarleio.github.io/konvert/
Apache License 2.0
86 stars 8 forks source link

Add options for default injection for koin injector #6

Closed jakoss closed 1 year ago

jakoss commented 1 year ago

From my experience pretty much all mappers we are using are annotated with @Factory. This PR adds the option for applying default annotations that apply (so it allows for @Factory, @Single and @Scope - even though i don't think there is much gain from shared scope for all of the mappers)

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.12 :tada:

Comparison is base (ef9e807) 82.22% compared to head (1eea9a1) 82.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6 +/- ## ========================================== + Coverage 82.22% 82.34% +0.12% ========================================== Files 57 59 +2 Lines 1845 1869 +24 Branches 265 268 +3 ========================================== + Hits 1517 1539 +22 - Misses 169 170 +1 - Partials 159 160 +1 ``` | [Impacted Files](https://app.codecov.io/gh/mcarleio/konvert/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marcel) | Coverage Δ | | |---|---|---| | [...in/io/mcarle/konvert/injector/koin/KoinInjector.kt](https://app.codecov.io/gh/mcarleio/konvert/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marcel#diff-aW5qZWN0b3JzL2tvaW4taW5qZWN0b3Ivc3JjL21haW4va290bGluL2lvL21jYXJsZS9rb252ZXJ0L2luamVjdG9yL2tvaW4vS29pbkluamVjdG9yLmt0) | `87.80% <86.66%> (-0.66%)` | :arrow_down: | | [...mcarle/konvert/injector/koin/config/KoinOptions.kt](https://app.codecov.io/gh/mcarleio/konvert/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marcel#diff-aW5qZWN0b3JzL2tvaW4taW5qZWN0b3Ivc3JjL21haW4va290bGluL2lvL21jYXJsZS9rb252ZXJ0L2luamVjdG9yL2tvaW4vY29uZmlnL0tvaW5PcHRpb25zLmt0) | `100.00% <100.00%> (ø)` | | | [.../mcarle/konvert/injector/koin/config/extensions.kt](https://app.codecov.io/gh/mcarleio/konvert/pull/6?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Marcel#diff-aW5qZWN0b3JzL2tvaW4taW5qZWN0b3Ivc3JjL21haW4va290bGluL2lvL21jYXJsZS9rb252ZXJ0L2luamVjdG9yL2tvaW4vY29uZmlnL2V4dGVuc2lvbnMua3Q=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mcarleio commented 1 year ago

Looks great, thanks for your work! :+1: