mcarton / rust-derivative

A set of alternative `derive` attributes for Rust
Apache License 2.0
420 stars 46 forks source link

Fix a clippy warning when using clone_from = "true" #77

Closed TeXitoi closed 3 years ago

TeXitoi commented 4 years ago

I also cleaned clippy warning in test, activated cargo clippy --all-targets to have clippy running on tests, and some fmt in the modified files.

Each modification is in a different commit, so I can remove some if you prefer.

Fixes #74

TeXitoi commented 4 years ago

Any feedbacks? I'd like to add clippy on CI, and I'm only blocked by this warning.

TeXitoi commented 4 years ago

Any news? @mcarton do you need help in maintaining this crate?

mcarton commented 3 years ago

Thanks, I cherry-picked some commits in #81 and released it as v2.1.3. I didn't merge this PR because it now had conflicts and I don't want to run rustfmt on the tests folder, as most of those tests are copied from rustc and I want to preserve them as much as possible.

TeXitoi commented 3 years ago

Thanks