mcasimir / gulp-rollup

gulp plugin for Rollup ES6 module bundler
MIT License
93 stars 12 forks source link

Add deprecation check for new Buffer #44

Closed zackschuster closed 8 years ago

zackschuster commented 8 years ago

The new Buffer pattern has been deprecated since v6.0.0 of node. If you're on that version or later, the proposed code will use Buffer.from instead.

lemmabit commented 8 years ago

I don't like the look of the version sniffing or the duplicated code. There's a ponyfill for Buffer.from called buffer-from on npm—no one else uses it for some reason, but it looks legit. I'll use that. Thanks for the heads-up.