search

mcasimir / mobile-angular-ui

Angular.js Mobile UI Framework with Bootstrap 3
http://mobileangularui.com/
MIT License
2.87k stars 709 forks source link

FastClick define module name for concat of vendor scripts? #108

Closed sgarbesi closed 10 years ago

sgarbesi commented 10 years ago

https://github.com/ftlabs/fastclick/issues/281

mcasimir commented 10 years ago

Sorry i can't understand.. what are u trying to do exactly? FastClick is already included and enabled in mobile-angular-ui. There is no problem in concatenating it unless U are trying to use something like browserify or require.js i'm not aware of any problem with it.

I'm just concatenating and using like this:

angular.module('mobile-angular-ui.fastclick', [])

.run([
  '$window', '$document', function($window, $document) {
    $window.addEventListener("load", (function() {
       FastClick.attach($document[0].body);
    }), false);
  }
])
sgarbesi commented 10 years ago

@mcasimir If you're working on a project with a dozen other libraries aside from just mobile-angular-ui and try to concat all of those libraries into a single vendor.js file so the client doesn't have to make a number of requests to your server when they initially hit your website, you'll get the error I referenced above.

mcasimir commented 10 years ago

Wait, I mean I already concatenate Fastclick in mobileangularui! It's just included into 'concatenated' mobile-angular-ui.js. U don't have to include it by yourself. Also I always concatenate mobileangularui with other libraries in any other projects. Concatenating is safe. If u get that error just concatenating is not related to fastclick or mobileangularui in any way. Unless U do anything fancy you shouldn't have problems. Check out http://mobileangularui.com/blog/your-first-phonegap-app-with-mobile-angular-ui/ and https://github.com/mcasimir/generator-mobileangularui to see a working example setup.

Check your config.