mcasimir / mobile-angular-ui

Angular.js Mobile UI Framework with Bootstrap 3
http://mobileangularui.com/
MIT License
2.87k stars 709 forks source link

Overthrow.js Referencing dist directory (which has been removed) #76

Closed lylepratt closed 10 years ago

lylepratt commented 10 years ago

The Overthrow.js project removed the dist/overthrow.js file. So that requirement now throws a Failed to load resource: the server responded with a status of 404 (Not Found) error.

Link to Overthrow.js commit detailing: https://github.com/filamentgroup/Overthrow/commit/de64083eed2786786e21978ef1b61f5bd3515b2e

jasonvillalon commented 10 years ago

I encounter thesame problem. my solution for now is navigate to overthrow directory in bower_components and run npm install. after that run grunt. it will generate the dist directory and files.

mcasimir commented 10 years ago

I don't understand.. is bower install throwing that error?

jasonvillalon commented 10 years ago

in my case when i bower install the mobile-angular-ui, Overthrow is installed since its a dependency. but there is no 'dist' in overthrow directory. i have to generate it manually. when i grunt serve my project dist/overthrow.js is a missing resource.

mcasimir commented 10 years ago

I'm sorry ..I think i'll need for a bit more explanation. What is grunt serve? Why do you need dist/overthrow.js?

This is how Overthrow.js is included in mobile-angular-ui sources:

    concat: {
      js: {
        files: {
          "dist/js/mobile-angular-ui.js": [
                "bower_components/overthrow/src/overthrow-detect.js",
                "bower_components/overthrow/src/overthrow-init.js",
                "bower_components/overthrow/src/overthrow-polyfill.js"
                /* , ... */
          ]
        }}},  /* ... */

Thus I can't understand why something is requiring dist/overthrow.js at all. Can you provide a little more details about that?

Thank you!

jasonvillalon commented 10 years ago

i think theres a little bit misunderstanding :) the thing is that when i installed mobile-angular-ui using bower install, when i run the task that injects the bower_components to my index.html, overthrow/dist/overthrow.js is also being injected. i believe this is because "main": "dist/overthrow.js", is included in .bower.json of overthrow.

mcasimir commented 10 years ago

ok.. so if this time I got it right.. isn't this an Overthrow issue? Or perhaps it is related to that task (grunt serve em I right?).

There is something I can do to fix it? Maybe If you find a way to make it work with grunt serve (ie. a particular setting for that task) I may put a note explaining that in Getting Started.

Anyway I think I'll close this for now. Let me know if I've to reopen it! Thank you

danpaulsmith commented 10 years ago

Try specifying the actual js file locations:

{
  "name": "overthrow",
  "version": "0.7.0",
  "main": [
    "src/overthrow-detect.js",
    "src/overthrow-init.js",
    "src/overthrow-polyfill.js",
    "src/overthrow-toss.js"
  ],
  "sidescroller": "src/overthrow.sidescroller.js",
  "ignore": [
    "examples",
    "test",
    "index.html"
  ]
}

in bower.json inside bower_components/overthrow in order to allow grunt to inject files into your index.html file properly.