search

mcasper / git-clean

A Command Line Tool written in Rust for cleaning up local and remote Git branches
MIT License
54 stars 9 forks source link

ignore a branch #25

Closed phoet closed 7 years ago

phoet commented 7 years ago

in order to implement https://github.com/mcasper/git-clean/issues/24

i think this is far from optimal, but at least it complied, so i'm happy for now 😸

from what i've seen, i think it would make sense to have a list of ignored branches where the base branch ie. master is in by default.

i would probably not do this through grep, but filter the list of branches after having clean input from git branch or something.

phoet commented 7 years ago

@mcasper the build is failing, but the test_git_clean_works_with_github_squashes did fail before my changes locally as well. so i assume master is broken at the moment.

mcasper commented 7 years ago

@phoet Yeah the test breakage isn't your fault, should be fixed on master now

phoet commented 7 years ago

thanks for the feedback, will try to get this done within the next days.

phoet commented 7 years ago

@mcasper please take another look at this, i think it's done

mcasper commented 7 years ago

One small change to the tests, otherwise it looks good!

mcasper commented 7 years ago

Looks great @phoet, thank you for the contribution!

phoet commented 7 years ago

@mcasper @skade thx for the feedback 😺