search

mcastorina / mpv-remote-app

Android app to control mpv running on another computer
GNU General Public License v3.0
85 stars 14 forks source link

Cryptographic APIs misuses #55

Open misterAnderson90 opened 2 years ago

misterAnderson90 commented 2 years ago

I'm a PhD student interested in finding security vulnerabilities in open source projects.

We found a total of 04 warnings (indicating potential vulnerabilities) when running the CogniCrypt static analyzer (*) on mpv-remote-app(or its library dependencies). We documented each one of these issues in private gists for the sake of confidentiality (non-disclosure).

Can you please let us know whether we can share these gists with you? We are eager to evaluate the perception of developers (e.g. severity of these warnings) and improve mpv-remote-app's security, and the quality of the reports of static analysis tools.

(*) https://github.com/CROSSINGTUD/CryptoAnalysis

mcastorina commented 2 years ago

Cool, thanks for reaching out! Please share :)

misterAnderson90 commented 2 years ago

Dear @mcastorina,

All warnings were related to the class HMAC.java

Gist 01 - SecretKeySpec Gist 02 - MAC Gist 03 - SecretKeySpec Gist 04 - MAC

For any doubts, you can comment directly in the gists and we can clarify the issues.

Best regards,