Closed bahamas10 closed 9 years ago
@bahamas10 To clarify, that error only happens with node 0.12, right?
@trentm correct. adding some debugging i can see that this.timeout
is undefined, but node 8 doesn't seem to have a problem accepting that as a value.
dave - sjc1-dave-01 sunos ~/dev/node-manta (git:master) $ node -v
v0.8.26
dave - sjc1-dave-01 sunos ~/dev/node-manta (git:master) $ ./bin/mls
timeout => undefined
...
it looks like this change https://github.com/joyent/node/commit/f34757398fcc393685b4dfbcbdc692fb38332d6c exposed this bug.
looking at the previous logic, it seems as though the timeout was just completely ignored (because of the invalid msecs
argument)
@pfmooney Do you have creds to commit here? You have creds for the npm registry for ssh-agent.
as is, if
options
is not supplied,this.timeout
will beundefined
which can cause an error to be throw whensocket.setTimeout
is called withundefined
.from
node-manta