search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

Make highlights case insensitive #115

Closed trag1c closed 1 year ago

trag1c commented 1 year ago

initially went with making them casefold during creation but reverted that since there already are highlights in different cases

also I think it's not that heavy to run .casefold() on the content every time (can change if needed tho)

Lunarmagpie commented 1 year ago

Should we not casefold the highlight before storing it in the database? That should make it a bit more performant by only having to casefold once per highlight. Would require some work for migration tho.

EDIT: or ig we can just not migrate and require users to manually update their highlights if they're not casefolded :trollface:. Only issue would be that we would need to keep some way to delete highlights that are not casefolded.

too much effort ngl