Closed qexat closed 2 years ago
1) Why not both 2) Could easily lead to false positives tbh
2) How so?
imo it'd be better if it just detected PEP mentions in messages, although it might be sometimes annoying
I agree but this can easily be a different PR
oh I forgot
removeprefix
isn't a thing in Py3.7 😔
technically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.
oh I forgot
removeprefix
isn't a thing in Py3.7 pensivetechnically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.
mypy complains about it though. Maybe it was added in 3.9, I don't remember.
It should finally be fine by now (I hope)
You didn't update the regex to use a named capture group
oh I forgot
removeprefix
isn't a thing in Py3.7 pensivetechnically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.
mypy complains about it though. Maybe it was added in 3.9, I don't remember.
indeed, str.removeprefix
and str.removesuffix
are 3.9 features
maybe we should bump to 3.10 (Ubuntu 22.04 ships with 3.10 so I think its a pretty good choice right now)
So we're waiting now for @CircuitSacul to approve, right?
lunar too I think :v
edit: and me))
@qexat Format with black so the CI can pass
@qexat Format with black so the CI can pass
Run nox -s apply-lint
to do black + isort + codespell in one shot
mfw you don't have a GPG key @trag1c @Endercheif
i do :trollface:
imo it'd be better if it just detected PEP mentions in messages, although it might be sometimes annoying