mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

feat: PEP command #39

Closed qexat closed 2 years ago

trag1c commented 2 years ago

imo it'd be better if it just detected PEP mentions in messages, although it might be sometimes annoying

trag1c commented 2 years ago

1) Why not both 2) Could easily lead to false positives tbh

2) How so?

Lunarmagpie commented 2 years ago

imo it'd be better if it just detected PEP mentions in messages, although it might be sometimes annoying

I agree but this can easily be a different PR

CircuitSacul commented 2 years ago

oh I forgot removeprefix isn't a thing in Py3.7 😔

technically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.

qexat commented 2 years ago

oh I forgot removeprefix isn't a thing in Py3.7 pensive

technically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.

mypy complains about it though. Maybe it was added in 3.9, I don't remember.

qexat commented 2 years ago

It should finally be fine by now (I hope)

CircuitSacul commented 2 years ago

You didn't update the regex to use a named capture group

trag1c commented 2 years ago

oh I forgot removeprefix isn't a thing in Py3.7 pensive

technically the minimum python version for mCodingBot is 3.8, so I don't think there's a problem with that.

mypy complains about it though. Maybe it was added in 3.9, I don't remember.

indeed, str.removeprefix and str.removesuffix are 3.9 features

Lunarmagpie commented 2 years ago

maybe we should bump to 3.10 (Ubuntu 22.04 ships with 3.10 so I think its a pretty good choice right now)

trag1c commented 2 years ago

So we're waiting now for @CircuitSacul to approve, right?

lunar too I think :v

edit: and me))

Enderchief commented 2 years ago

@qexat Format with black so the CI can pass

Lunarmagpie commented 2 years ago

@qexat Format with black so the CI can pass

Run nox -s apply-lint to do black + isort + codespell in one shot

Enderchief commented 2 years ago

mfw you don't have a GPG key @trag1c @Endercheif

i do :trollface: