search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

handle deletes & edits for pep responses #53

Closed CircuitSacul closed 2 years ago

CircuitSacul commented 2 years ago

https://files.circuitsacul.dev/Screen_Recording_2022-09-13_at_8.41.36_PM.mov

trag1c commented 2 years ago

You changed 60 * 5 to 60 + 5?

CircuitSacul commented 2 years ago

You changed 60 * 5 to 60 + 5?

Originally I hardcoded it to 5 minutes. Then I decided to just make it 5 seconds longer than the "MAX_AGE_FOR_SEND".

trag1c commented 2 years ago

You changed 60 * 5 to 60 + 5?

Originally I hardcoded it to 5 minutes. Then I decided to just make it 5 seconds longer than the "MAX_AGE_FOR_SEND".

Then just do timedelta(minutes=1, seconds=5) or timedelta(seconds=65)?

CircuitSacul commented 2 years ago

You changed 60 * 5 to 60 + 5?

Originally I hardcoded it to 5 minutes. Then I decided to just make it 5 seconds longer than the "MAX_AGE_FOR_SEND".

Then just do timedelta(minutes=1, seconds=5) or timedelta(seconds=65)?

No because the TTL is directly based on the MAX_AGE_FOR_SEND constant. It needs to be just a little bit longer than that.

Lunarmagpie commented 2 years ago

re, crescent, and hikari do not use from imports. This PR should stay consistent with the rest of the file.

Seems the imports are from for anything in the project and typing. import for everything else.