search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

Make class commands into functions #57

Closed Lunarmagpie closed 1 year ago

Lunarmagpie commented 2 years ago

removes an unnecessary parameter and indentation level. I think the code is also clearer when it doesn't have a class that doesn't really do any class things.

And its prettier tbh.

CircuitSacul commented 2 years ago

My personal opinion is to only use class-commands for consistency. But if @trag1c agrees with you, then I'm fine with this change.

trag1c commented 2 years ago

Is there any benefit to using classes?

Lunarmagpie commented 2 years ago

Is there any benefit to using classes?

Readability for command options. So none in this case.

trag1c commented 2 years ago

Is there any benefit to using classes?

Readability for command options. So none in this case.

Go for functions then

Lunarmagpie commented 2 years ago

class commands are slower than function commands as well :trollface:

CircuitSacul commented 2 years ago

Is there any benefit to using classes?

Consistency, since all commands currently use classes. This PR makes it so that only commands with options have classes.

Lunarmagpie commented 2 years ago

Bump