search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

CONTRIBUTING.md #59

Closed Lunarmagpie closed 1 year ago

Lunarmagpie commented 2 years ago

This is a rough draft. maintianers feel free to change anything, but we have to agree on it before its merged.

Lunarmagpie commented 1 year ago

Waiting for @CircuitSacul to set this to the version of Contributing.md on his markdown website thing

CircuitSacul commented 1 year ago

CONTRIBUTING.md

Lunarmagpie commented 1 year ago

Is this still a draft?

MithicSpirit commented 1 year ago

Please make all lines at most 80 characters long so I can read this on a standard ISO/ANSI screen. There is a reason markdown treats single newlines as spaces rather than paragraph breaks.

EDIT: submitted as a change request.

Lunarmagpie commented 1 year ago

I am ok with merging in the current state, want the other maintainers to review tho.

Lunarmagpie commented 1 year ago

Honestly I can not be bothered to fix the formatting. If you want it @MithicSpirit then pr/push it into my branch.

MithicSpirit commented 1 year ago

Vim can word wrap with gq or gw, but I can also do it later when I have time.

Lunarmagpie commented 1 year ago

Just changed the max line length manually

trag1c commented 1 year ago

Should code blocks specify their language as bash or smth?

No need, I added it for the nox one specifically so that comments are highlighted properly

Lunarmagpie commented 1 year ago

Merging is blocked until mithic gives a positive review

trag1c commented 1 year ago

yep, waiting for @MithicSpirit

MithicSpirit commented 1 year ago

Waiting on https://github.com/Lunarmagpie/mCodingBotRewrite/pull/1 to give positive review.

Lunarmagpie commented 1 year ago

Didn't see that PR sorry. Merged now.