search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

fix: use custom helper function instead of `round` #64

Closed qexat closed 2 years ago

Enderchief commented 2 years ago

Is this PR even needed? We do not need for the latency to be precise. When people use /ping they are either doing it just because they want to or to see an approximate. Values of +-1 are not a issue like it is made to be. It would make sense for this PR if we were monitoring the latency over a period of time but alas we are not.

Lunarmagpie commented 2 years ago

I agree with endercheif. The cost of this is kinda high for what we get out of it.

trag1c commented 2 years ago

I agree with endercheif. The cost of this is kinda high for what we get out of it.

How is the cost high?

Lunarmagpie commented 2 years ago

Readability cost of an unexpected function /shrug i dont care about performance

Lunarmagpie commented 2 years ago

How the function makes the code less readable? raised_eyebrow

Reader has to check why regular round isn't being used

circuitsacul commented 2 years ago

Why close?

Lunarmagpie commented 2 years ago

I meant that comment thread to change the impl of natural_round was about a problem that didn't need changing. Its fine how it is.