Basic highlight feature

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.

https://mcoding.io/discord

MIT License

12 stars 4 forks source link

Basic highlight feature #70

Closed Lunarmagpie closed 1 year ago

Lunarmagpie commented 1 year ago

[X] Add/remove highlights
[X] Cache highlights
[X] dm user
[x] Pretty display for highlights list and highlights dm (assigned to @CircuitSacul)
[x] Consider different logic for User.delete_word
[x] Investigate typing with fetchmany
[ ] ~~Support regex~~ moving to different PR
[x] Decide to limit highlights or not (limited to 25)

CircuitSacul commented 1 year ago

Investigate typing with fetchmany

I assume you're referring to the fact that the return types for ManyToMany are broken. If you update apgorm in this branch too, that will be fixed.

Lunarmagpie commented 1 year ago

I assume you're referring to the fact that the return types for ManyToMany are broken. If you update apgorm in this branch too, that will be fixed.

Yes, I checked the source code locally and there was a problem with apgom. Was up to date tho. Just noticed you made a new release

CircuitSacul commented 1 year ago

I assume you're referring to the fact that the return types for ManyToMany are broken. If you update apgorm in this branch too, that will be fixed.

Yes, I checked the source code locally and there was a problem with apgom. Was up to date tho. Just noticed you made a new release

I just now made a release. The fix has been sitting in the repo, but I hadn't pushed it to pypi yet.

Lunarmagpie commented 1 year ago

Only visuals are left. I don't have any ideas and don't really feel like spending my time implementing anything so someone else can do it.

CircuitSacul commented 1 year ago

Only visuals are left. I don't have any ideas and don't really feel like spending my time implementing anything so someone else can do it.

I'll do that part then

CircuitSacul commented 1 year ago

We should also make it ignore the person who owns the highlight. Like, if I have "1984" highlighted and then I say 1984, it shouldn't notify me.

Lunarmagpie commented 1 year ago

Thats really important. Also may require a bit of a rework?