search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

Added reaction and link #79

Closed soupless closed 1 year ago

soupless commented 1 year ago

Added 💀 react for messages having the word "forgor" and a 💀 and included https://mcoding.io in the links command.

Lunarmagpie commented 1 year ago

The link changes and forgor message shouldn't be done in the same PR. May seem pedantic but I want to keep different purposes for PRs separated.

soupless commented 1 year ago

Are changes supposed (or recommended) to be in different PRs, instead of one? I thought changes should be bundled as much as possible.

Lunarmagpie commented 1 year ago

One PR should do one task. Otherwise, maintainers have a harder time reviewing and the larger amount to review can lead to longer reviews. Also for a repository that squashes commits it leads to a easier to read commit history.

trag1c commented 1 year ago

Closing this due to inactivity