Highlight Cooldowns

[CircuitSacul]

This makes a few changes to improve highlights

• [x] If a message contains multiple triggers, combine them into a single DM.
• [x] Have a cooldown of 30s per (highlight, user, channel)
• [x] If a user sends a message in a channel, don't send them any highlights for the next minute.

These are just my feel for how it should work. If you think it should be tweaked lmk.

[MithicSpirit]

These changes sound good to me, though please make the two cooldowns relatively easy to configure (like MAX_HIGHLIGHTS and MAX_HIGHLIGHT_LENGTH).

Might be interesting for us to look into having a proper config file for these things in the future (maybe we can commandeer the config.json for these purposes?).

[CircuitSacul]

These changes sound good to me, though please make the two cooldowns relatively easy to configure (like MAX_HIGHLIGHTS and MAX_HIGHLIGHT_LENGTH).

Might be interesting for us to look into having a proper config file for these things in the future (maybe we can commandeer the config.json for these purposes?).

Well these things would undoubtedly be defined in config.json (with defaults in config.py). Unless you meant per-user configuration? I think that's possible too.

[Lunarmagpie]

Well these things would undoubtedly be defined in config.json (with defaults in config.py). Unless you meant per-user configuration? I think that's possible too.

I think moving all config options to config.py would be a good idea. May open a PR for that before this one gets merged.

[MithicSpirit]

Well these things would undoubtedly be defined in config.json (with defaults in config.py). Unless you meant per-user configuration? I think that's possible too.

MAX_HIGHLIGHTS and MAX_HIGHLIGHT_LENGTH aren't in config.json :p. As for per-user configuration, it would be nice but probably overkill for now.

[CircuitSacul]

MAX_HIGHLIGHTS and MAX_HIGHLIGHT_LENGTH aren't in config.json :p. As for per-user configuration, it would be nice but probably overkill for now.

Oh oof. They should've been. Well, I'll be putting these settings in config. And yeah, per-user config is outside the scope of this pr anyways

[CircuitSacul]

This is done. Ready for review.

[Lunarmagpie]

Still would prefer if NamedTuple was used.

[CircuitSacul]

Actually the bucket should probably be SentMessageBucket

I just named it "UserChannelBucket" b/c that's what it is literally

[Lunarmagpie]

I just named it "UserChannelBucket" b/c that's what it is literally

No reason to say the properties of the class. Makes more sense to name it so its clear where its being used.