search

mcb-dev / mCodingBot

The Discord bot for the mCoding Discord server.
https://mcoding.io/discord
MIT License
12 stars 4 forks source link

Add `poetry update` to restart script #87

Closed Lunarmagpie closed 1 year ago

Lunarmagpie commented 1 year ago

Dependencies should be updated when the bot restarts since there isn't a lockfile in the repo

Lunarmagpie commented 1 year ago

I dont think poetry update installs the mcodingbot package, but idk if that matters.

Lunarmagpie commented 1 year ago

Before, otherwise install would install outdated dependencies.

MithicSpirit commented 1 year ago

I dont think poetry update installs the mcodingbot package, but idk if that matters.

ah, true. Probably should keep the install in regardless @CircuitSacul (ping bc moved out of review for some reason ahem)

MithicSpirit commented 1 year ago

I am still of the opinion we should keep a lockfile on some stable branch (which is where the bot pulls from) and remove it on a dev branch (which is where pull requests are made to), but whatever.

CircuitSacul commented 1 year ago

I am still of the opinion we should keep a lockfile on some stable branch (which is where the bot pulls from) and remove it on a dev branch (which is where pull requests are made to), but whatever.

I'm starting to agree with you, tbh, but I think this is good for now.

Lunarmagpie commented 1 year ago

I am still of the opinion we should keep a lockfile on some stable branch and remove it on a dev branch (which is where pull requests are made to), but whatever.

No reason to use poetry otherwise. We could migrate to setuptools with the current setup and it would be easier for new contributors lol.

Lunarmagpie commented 1 year ago

I don't approve of removing the lockfile but whatever

The lockfile was gone anyway for some reason?