mcbssds / IFISS_download

Latest version of IFISS software
BSD 2-Clause "Simplified" License
6 stars 1 forks source link

Checking in source code instead of tar file #1

Open lindsayad opened 5 months ago

lindsayad commented 5 months ago

Hi, thank you so much for sharing this great software freely with the community. I was wondering if your development team would be willing to check in the matlab files themselves instead of a tar file? Version control would make more sense on that level and it would also enable commands like git grep. I would be happy to make a pull request making that change as well. Although it might make more sense to rename the repository if you make that change. Note that github can create tar files for you for tagged releases

mcbssds commented 4 months ago

Alex We would prefer to keep things simple at this stage. The software package is divided into multiple directories and has over 600 component (m-)files. A single download is surely the best way for users to install the software. ---David


From: Alex Lindsay @.***> Sent: 24 April 2024 16:52 To: mcbssds/IFISS_download Cc: Subscribed Subject: [mcbssds/IFISS_download] Checking in source code instead of tar file (Issue #1)

Hi, thank you so much for sharing this great software freely with the community. I was wondering if your development team would be willing to check in the matlab files themselves instead of a tar file? Version control would make more sense on that level and it would also enable commands like git grep. I would be happy to make a pull request making that change as well. Although it might make more sense to rename the repository if we make that change. Note that github can create tar files for you for tagged releases

— Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https://github.com/mcbssds/IFISS_download/issues/1__;!!PDiH4ENfjr2_Jw!FCigrqQGk9q8nRyHw0OFhzW-UnCmgmX6LUVXmwj3NLY3qJw6HrGLb12i_9dLUdjT5mJ3EWcQAGEo4jjRSjpyCROSxnWWn6Uf$, or unsubscribe [github.com]https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AYZSJCABWMTK4O54ULRXO33Y67INLAVCNFSM6AAAAABGXGHJQ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DCNRTGEZTAMQ__;!!PDiH4ENfjr2_Jw!FCigrqQGk9q8nRyHw0OFhzW-UnCmgmX6LUVXmwj3NLY3qJw6HrGLb12i_9dLUdjT5mJ3EWcQAGEo4jjRSjpyCROSxgzVeCfc$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

lindsayad commented 4 months ago

A user can choose to download a single zipped file if they want. See screenshot below. Git is designed for tracking changes to large numbers of files. The software package I lead has 40,839 files currently checked in with more added every day.

Screenshot 2024-04-29 at 11 05 30 AM
lindsayad commented 4 months ago

Whether you check-in the 600 files with git and do git clone, or clone the tar file and then untar, the result is the same in terms of final file count for the user isn't it? But in the former, it's only one step

lindsayad commented 4 months ago

As I said, I very much appreciate you guys sharing your code, so I will be happy even if you don't change anything. It was just a suggestion

mcbssds commented 4 months ago

No problem. We will leave the setup as it is for now ... and monitor the download activity. ---David


From: Alex Lindsay @.***> Sent: 29 April 2024 21:51 To: mcbssds/IFISS_download Cc: David Silvester; Comment Subject: Re: [mcbssds/IFISS_download] Checking in source code instead of tar file (Issue #1)

As I said, I very much appreciate you guys sharing your code, so I will be happy even if you don't change anything. It was just a suggestion

— Reply to this email directly, view it on GitHub [github.com]https://urldefense.com/v3/__https://github.com/mcbssds/IFISS_download/issues/1*issuecomment-2083640908__;Iw!!PDiH4ENfjr2_Jw!A17ca1tE_nhqhFpsIFuyZBNLHRCzoR7-16rH2WlA0omF38LOg0lW9nNJnoP4OetcXv5K3IoqmaBdH-3ojNBgdJPNCYzIFBL3$, or unsubscribe [github.com]https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AYZSJCFJMFQMG7ESZGJFGJ3Y72XGXAVCNFSM6AAAAABGXGHJQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBTGY2DAOJQHA__;!!PDiH4ENfjr2_Jw!A17ca1tE_nhqhFpsIFuyZBNLHRCzoR7-16rH2WlA0omF38LOg0lW9nNJnoP4OetcXv5K3IoqmaBdH-3ojNBgdJPNCd4ZG6SR$. You are receiving this because you commented.Message ID: @.***>