search

mccalltd / AttributeRouting

Define your routes using attributes on actions in ASP.NET MVC and Web API.
http://mccalltd.github.io/AttributeRouting/
MIT License
416 stars 89 forks source link

For consideration: Add explicit support for globalized routes #14

Closed utilityboy closed 12 years ago

utilityboy commented 13 years ago

Hi,

First off, this is a great library. Thanks so much for the investment of time and effort... very well put together.

Earlier this week I spent a bunch of time faffing around with culture switching based on locale route parameters. Any thoughts on adding some defaults into your library to help with this?

I'm a little crunched for time right now, but if you think it's a good idea, I wouldn't mind throwing a few hours towards a nice implementation.

Thanks again,

...brent

mccalltd commented 13 years ago

Thanks Brent,

So you want to get a route param with culture info and then switch the culture of the current thread, yes?

From what I understand about changing the culture in the current thread, it might be too late to do that by the time AR handles a request. Usually I've set culture stuff for the thread in the Application_BeginRequest method in global.asax. There you'd have access to the current request and could pick off query string params, user languages, etc.

I had spiked out a localization solution, which I am not sure would be relevant here. You can view the localization branch in the github repo if you would like.

Let me know if I am missing the point.

t

On Aug 26, 2011, at 11:39 AM, bjubinville wrote:

Hi,

First off, this is a great library. Thanks so much for the investment of time and effort... very well put together.

Earlier this week I spent a bunch of time faffing around with culture switching based on locale route parameters. Any thoughts on adding some defaults into your library to help with this?

I'm a little crunched for time right now, but if you think it's a good idea, I wouldn't mind throwing a few hours towards a nice implementation.

Thanks again,

...brent

Reply to this email directly or view it on GitHub: https://github.com/mccalltd/AttributeRouting/issues/14

utilityboy commented 13 years ago

It's true, with web apps you would set the culture in BeginRequest traditionally, but I've done a little work on a decent looking solution that I'm happy to share (and that I think my have a place here). I'll get back to you in a couple weeks with some more discussion points. Thanks for the response.

mccalltd commented 12 years ago

Any progress? Would like to include localization support but have been slammed recently with a job, of all things.

utilityboy commented 12 years ago

Sadly, I'm in the same boat. It's still on my list to look at, but I can't say when I'll be able to get a chance.

mccalltd commented 12 years ago

I just added the first crack at localization support in v1.5, now available on nuget. FYI.