search

mccalltd / AttributeRouting

Define your routes using attributes on actions in ASP.NET MVC and Web API.
http://mccalltd.github.io/AttributeRouting/
MIT License
416 stars 89 forks source link

Web Activator nuget #233

Closed john-t-white closed 11 years ago

john-t-white commented 11 years ago

I added your package in Visual Studio Express 2012 and it has a dependency on Web Activator. I already have web activator and it appears to reference a different one. The one I have already downloaded is the one that is signed and it is looks like you guys depend on the one that is not signed. I don't seem to have the same problem in Visual Studio 2010. Can you modify it to use the new one.

Thanks

Sebazzz commented 11 years ago

AttributedRouting references WebActivator 1.0 instead of WebActivatorEx (WebActivator 2.0). WebActivator 2.0 works correctly with AttributedRouting though, it is only a NuGet package issue.

See also: #237

quickstar commented 11 years ago

I'd like to see the signed WebActivator referenced, because in production code it's very common to sign your assemblies. If you do so your no longer able to use the whole AttributeRouting package at all. Is there any reason not to upgrade?

Sebazzz commented 11 years ago

AttributedRouting itself has no dependency on WebActivator. The nuget package hoever, does. The nuget package injects code into App_Start which depends on WebActivator. It is however perfectly possible to install the package, remove WebActivator reference from project, install WebActivatorEx and fix the references in the added code files from the package. This is an operation that needs to be performed only once, when the package is installed for the first time.

The author of the WebActivator recommends to use WebActivatorEx instead of WebActivator.

quickstar commented 11 years ago

Hi Sebazzz

Thanks for your response! I've totally removed the WebActivator dependency and registering the routes within Application_Start from global.asax. Although it would be pretty handy to have a package without the WebActivator dependency.

Regards, Lukas

pjklein commented 11 years ago

@mccalltd, this is fixed in my pull request.

mccalltd commented 11 years ago

Fixed via https://github.com/mccalltd/AttributeRouting/pull/252

youngcm2 commented 10 years ago

Will the nuget packages be pushed?

pjklein commented 10 years ago

Doubtful. About this time last year, @mccalltd was working with Microsoft to incorporate AttributeRouting into ASP.Net Web API v2 and ASP.Net MVC 5. I suggest you switch to using those. I did.