mccarthy-m-g / palettes

Methods for working with colour palettes in R
https://mccarthy-m-g.github.io/palettes/
Other
21 stars 1 forks source link

Export lighten and darken functions? #24

Open EllaKaye opened 1 year ago

EllaKaye commented 1 year ago

I notice that the code base has functions for lightening/darkening colour palettes and vectors but these are not exported. Any reason why not? They would be nice to have!

mccarthy-m-g commented 1 year ago

They would! I’m aiming to export these in v0.2.0 or v0.3.0.

I got a bit ahead of myself adding them to the code base, but didn’t want to export them yet because I’m still debating whether to wrap the relevant functions from the prismatic package (like it is now), or to write my own internals.

I do want to add colour manipulation functions that match a lot of what’s in prismatic (e.g., greyscale, saturate, etc.), so the dependency makes sense. But some of the functions there are missing options that might be nice.

For example, for lightening and darkening, prismatic only lets you change by a relative amount, but being able to supply an absolute amount too might be nice if you wanted all colours in a palette to have the same luminance. What do you think?

EllaKaye commented 1 year ago

Good that you have a road map for further development on the package - I'm excited to see where it goes!

Yes, having all colour the same luminance could be a nice option. Would take some thinking about though, given that not all combinations of Hue/Chroma/Luminance exist in HCL space (as I'm sure you know).

mccarthy-m-g commented 1 year ago

Me too! I can make a proper issue tracking features I’m thinking of if you’d like a public roadmap.

I’m actually learning all these colour science facts and problems as I go 😅 If I go with my own solution I’d probably base it off the formulas colorspace is using.

EllaKaye commented 1 year ago

Learning as you go is the best way! That's what I did when I made a custom syntax highlighting theme then wrote a blog post about it.

I'd be intrigued to see a road map, but only if it doesn't put too much pressure on you 😅 Once I finish my thesis (mid-Feb) I'd also be happy to contribute, if you'd like/that would be useful/there's a feature I actually know how to implement!

mccarthy-m-g commented 1 year ago

Nice post! I like what you’ve done with your site too, looks great!

I’d be happy to have you as a contributor! I’ll make a simple road map with a task list tracking different issues; should make it easier to see what I need help with 😄