search

mccgr / edgar

Code to manage data related to SEC EDGAR
31 stars 15 forks source link

Fix $EDGAR_CODE_DIR #68

Closed iangow closed 4 years ago

iangow commented 4 years ago

The environment variable EDGAR_CODE_DIR should be set in the cron job and there should be a cd $EDGAR_CODE_DIR there. This should not appear in code in this repository.

bdcallen commented 4 years ago

@iangow Ok, I have made the changes to the bash scripts, and changed my crontab to 

26 17 * * * $CODE_DIR/./asx_prev_day_cronjob.sh
00 21 * * * cd $EDGAR_CODE_DIR && ./update_edgar.sh
00 0 * * * cd $EDGAR_CODE_DIR && ./update_forms_345_tables.sh
00 6 * * 5 $ABN_LOOKUP_DIR/./abn_lookup_cronjob.sh
00 3 * * 4 $ASIC_DIR/./asic_bulk_extract_cronjob.sh

Will this affect the other cronjobs in the crontab?

iangow commented 4 years ago

Checking one of these, it seems that ASIC_DIR is still in the code. I think you should assume that the code is run from the root directory of the local repository. If that's ASIC_DIR, then there's no need to use ASIC_DIR in the code in the repository.

Links for:

iangow commented 4 years ago

I think each of the four above implies an issue like this one in the appplicable repository.

bdcallen commented 4 years ago

@iangow I agree. I will open issues for all of them, then fix them and close

bdcallen commented 4 years ago

@iangow Ok, this issue is fixed, as EDGAR_CODE_DIR no longer appears in the code in the repository. Closing now.