Closed mcchrish closed 2 years ago
The change looks good. Although I feel like it should be guarded by some config var in case someone wants to use some other binding to
But if we want to remove the guard and enable it all the time, then we'll have to update the docs on that as well.
I'm wondering if it also makes sense to map :
to normal mode :
. It's common enough to be added as default. What do you think?
Also are there more default mappings that can be handy?
I'm wondering if it also makes sense to map : to normal mode :. It's common enough to be added as default. What do you think?
I was actually thinking about this as well. nnn
doesn't seem to have any default binding set to :
so it should be okay.
I realized it might not be ideal to map :
. It will be triggered even during times like renaming/creating files or any other state nnn is in.
I think we can just map to normal mode that wall all will just work not just the four mappings we created.
Also I think it make sense that it should always be mapped regardless of
set_default_mappings
.set_default_mappings
is if they want to get rid of<leader>n
.