.cpp files have spurious #ifdef __cplusplus - Githubissues

mcci-catena / Catena-Arduino-Platform

Arduino platform library for MCCI Catena IoT Systems

MIT License

12 stars 11 forks source link

.cpp files have spurious #ifdef __cplusplus #127

Closed terrillmoore closed 5 years ago

terrillmoore commented 5 years ago

The following files use #ifdef __cplusplus. This should be corrected, because .cpp files (unlike .h files) can not be anything else.

The C-isms should also be corrected.

Don't use #define in C++ files unless there's no alternative. #define can almost always be replaced by constexpr
Don't declare local functions extern "C" -- they can (and should) be C++, or even converted to private method functions.

My guess is that these are cut/paste errors after refactorings.

terrillmoore commented 5 years ago

I've corrected this. Will push a patches later today.