search

mcci-catena / Catena-Arduino-Platform

Arduino platform library for MCCI Catena IoT Systems
MIT License
12 stars 11 forks source link

Fix #135: Added the Platform support for Catena 4630/4617/4618 #174

Closed dhineshkumarmcci closed 5 years ago

dhineshkumarmcci commented 5 years ago

Added Catena Platform library support for Catena 4630 device.

terrillmoore commented 5 years ago

We cannot merge this, per policy, until build passes. This means that you must first update teh BSP, then clear the cache, then trigger a new build. Please also push the commits on this pull request for the 4617 and 4618 (#173), so we can avoid too much thrash.

dhineshkumarmcci commented 5 years ago

@terrillmoore As this pull request is for adding the platform support for new boards, is this correct to update the version to (0, 15, 0, 0) /* v0.15.0.0 */ in the below line? https://github.com/mcci-catena/Catena-Arduino-Platform/blob/97eda5fce317d2fb6b4c97a8ec0d3fbf71ec92df/src/CatenaBase.h#L58

terrillmoore commented 5 years ago

@terrillmoore As this pull request is for adding the platform support for new boards, is this correct to update the version to (0, 15, 0, 0) /* v0.15.0.0 */ in the below line?

https://github.com/mcci-catena/Catena-Arduino-Platform/blob/97eda5fce317d2fb6b4c97a8ec0d3fbf71ec92df/src/CatenaBase.h#L58

Not yet. That only gets to be 0.15.0.0 when we make a new release (as in a tag and formal release process). Bump this to 0.14.70.0 for now.

terrillmoore commented 5 years ago

Please also check the conflicts that are reported by github.