search

mcci-catena / Catena-Arduino-Platform

Arduino platform library for MCCI Catena IoT Systems
MIT License
12 stars 11 forks source link

Removed use of Adafruit_FRAM_I2C in Catena_Fram2k.h #218

Closed kent-williams closed 4 years ago

kent-williams commented 4 years ago

Hello,

I've just begun using the Catena 4610 and ran into some issues when attempting to compile your examples. Catena_Fram2k is attempting to use Adafruit_FRAM_I2C with the wrong function names and parameters, which Adafruit_FRAM_I2C has never had. I swapped the adafruit lib with Catena_Mb85rc64ta and the examples compile successfully now. Not entirely sure that the use of Catena_Mb85rc64ta will work during runtime, so I'll leave that up to you.

-Kent

kent-williams commented 4 years ago

Ok, I think I just found out what's going on. You're using your own fork of https://github.com/mcci-catena/Adafruit_FRAM_I2C.

terrillmoore commented 4 years ago

Hi @kent-williams ,

Thanks for your contribution and sorry for the problems.

Though it's lamentably not clear, we have our own forks of all the libraries we use; and in some cases, we've modified them. You should try with https://github.com/mcci-catena/Adafruit_FRAM_I2C and see if that helps. Our roll-up of sketches in https://github.com/mcci-catena/catena-sketches has a script, git-boot.sh and a number of git-repos.dat files, which reduce the pain somewhat. In the beginning, I avoided git submodules because of the usability issues, but the cure may be worse than the disease.

kent-williams commented 4 years ago

Going to close this as it's clear what is going on.

It would be very helpful to add a note in this repo mentioning that your Adafruit_FRAM_I2C fork is required.

kent-williams commented 4 years ago

Hi @kent-williams ,

Thanks for your contribution and sorry for the problems.

Though it's lamentably not clear, we have our own forks of all the libraries we use; and in some cases, we've modified them. You should try with https://github.com/mcci-catena/Adafruit_FRAM_I2C and see if that helps. Our roll-up of sketches in https://github.com/mcci-catena/catena-sketches has a script, git-boot.sh and a number of git-repos.dat files, which reduce the pain somewhat. In the beginning, I avoided git submodules because of the usability issues, but the cure may be worse than the disease.

Thanks for the help @terrillmoore ! I'll give that a try!

terrillmoore commented 4 years ago

Filed bug #219, will update the README.