search

mcci-catena / Catena-Arduino-Platform

Arduino platform library for MCCI Catena IoT Systems
MIT License
12 stars 11 forks source link

Catena455x, 461x, 461x need to establish FRAM invariants (like SAMD boards) #89

Closed terrillmoore closed 5 years ago

terrillmoore commented 5 years ago

In the Catena wing support, we have:

https://github.com/mcci-catena/Catena-Arduino-Platform/blob/163b63653a439375a61029b9e1d4e029a1c309de/src/lib/samd/catenawingfram2k/CatenaWingFram2k_begin.cpp#L69-L82

The equivalent points for the 455x and similar boards are:

https://github.com/mcci-catena/Catena-Arduino-Platform/blob/163b63653a439375a61029b9e1d4e029a1c309de/src/lib/stm32/catena455x/Catena455x_begin.cpp#L72-L76

https://github.com/mcci-catena/Catena-Arduino-Platform/blob/163b63653a439375a61029b9e1d4e029a1c309de/src/lib/stm32/catena461x/Catena461x_begin.cpp#L66-L71

https://github.com/mcci-catena/Catena-Arduino-Platform/blob/163b63653a439375a61029b9e1d4e029a1c309de/src/lib/stm32/catena480x/Catena480x_begin.cpp#L66-L71

All these locations need to be fixed. (And see #65 -- all these routines could be combined if we had this->GetFram() and used it instead of directly using this->m_fram).

terrillmoore commented 5 years ago

This report is mistaken; it's already done by CatenaStm32L0::begin().