Compilation failures with 1.8.8

[jchonig]

Arduino: 1.8.8 (Mac OS X), Board: "MCCI Catena 4450, North America 915 MHz"

catena4450m101_sensor:85:45: error: 'void txFailedDoneCb(osjob_t*)' was declared 'extern' and later 'static' [-fpermissive]
static void txFailedDoneCb(osjob_t *pSendJob);
^
catena4450m101_sensor:599:6: error: previous declaration of 'void txFailedDoneCb(osjob_t*)' [-fpermissive]

  ^

catena4450m101_sensor:87:40: error: 'void sendBufferDoneCb(void, bool)' was declared 'extern' and later 'static' [-fpermissive] static Arduino_LoRaWAN::SendBufferCbFn sendBufferDoneCb; ^ catena4450m101_sensor:574:6: error: previous declaration of 'void sendBufferDoneCb(void, bool)' [-fpermissive]

  ^

exit status 1 'void txFailedDoneCb(osjob_t*)' was declared 'extern' and later 'static' [-fpermissive]

This report would have more information with "Show verbose output during compilation" option enabled in File -> Preferences.

[terrillmoore]

@jchonig discovered that this is to splitting a function definition into two lines; see #46. Arduino IDE 1.8.8 doesn't like:

static void
somefunction()
    {
    // body
    }

It wants

static void somefunction()
   {
   // body
   }

Can't fight city hall on this one.