mcci-catena / arduino-lmic

LoraWAN-MAC-in-C library, adapted to run under the Arduino environment
https://forum.mcci.io/c/device-software/arduino-lmic/
MIT License
650 stars 212 forks source link

FAILURE ...\radio.c:750 #211

Closed E2w4UmWh closed 5 years ago

E2w4UmWh commented 5 years ago

Hello all,

I'm running a dragino LoRa Shield v1.4 on an Arduino Uno on 433 MHz. Arduino reports me the following error: FAILURE ...\radio.c:750

I have no clue, where to start from the debugging, as I do not understand the goal of the code around line 750. Any hint, how to proceed is welcome ...

terrillmoore commented 5 years ago

I'm looking at line 750 and there's no assert there. Are you sure you're using this code base? (Also, I haven't added 433MHz support, so it seems likely you're using a different repo.)

The code in this region in our codebase looks like this. https://github.com/mcci-catena/arduino-lmic/blob/23e6d5e4c555f6987b4703f3b2c79c6d04b29319/src/lmic/radio.c#L745-L755

There's an assert at line 746, and it seems possible that additional code was added above for 433 MHz support in your codebase, but ... there's nothing at line 750, so I'm just guessing. I would guess that the problem is from the introduction of 433 MHz support. I'll be happy to review that if someone sends a pull request.

I'm going to close this because of the apparent mismatch.