mcci-catena / arduino-lmic

LoraWAN-MAC-in-C library, adapted to run under the Arduino environment
https://forum.mcci.io/c/device-software/arduino-lmic/
MIT License
650 stars 212 forks source link

LMIC compliance code doesn't handle DLCounter correctly #267

Closed terrillmoore closed 5 years ago

terrillmoore commented 5 years ago

The downlink counter is not the downlink sequence number. It's the count of messages received by the compliance module (or so it seems). Need to update the compliance code to count messages in the way the compliance test expects.

terrillmoore commented 5 years ago

With the changes in https://github.com/mcci-catena/arduino-lmic/commit/4d88dfac9cd775738f9eb372cca0ce6dc8b470cf, we now pass sections 1, 2, and 3 of the US Certification test in the RWC 5020A tester:

image

I'll generate a pull request as soon as the branch build is finished.