search

mcci-catena / arduino-lmic

LoraWAN-MAC-in-C library, adapted to run under the Arduino environment
https://forum.mcci.io/c/device-software/arduino-lmic/
MIT License
643 stars 210 forks source link

SPI.begin() variants #37

Closed vshymanskyy closed 5 years ago

vshymanskyy commented 6 years ago

On some boards, SPI.begin() is used to set SPI pins:

SPI.begin(5,19,27,18);

Currently, this is hardcoded in the library, but it may be best to leave it for the user sketch. https://www.thethingsnetwork.org/forum/t/big-esp32-sx127x-topic/10247/131

terrillmoore commented 6 years ago

Good idea. We can add this to the pin map, I think.

cyberman54 commented 6 years ago

@terrillmoore I could need this, too, for my paxcounter software which supports generic boards.

cyberman54 commented 6 years ago

Suggested implemenation with pull request #157

terrillmoore commented 6 years ago

Unfortunately, I discovered that my suggestion of adding to the pinmap can't work on Adafruit BSPs. Sigh. Plus (after suggesting that) I learned that changing the pinmap can be a major breaking change. See my comments on #157.

terrillmoore commented 5 years ago

This is closed by #190.