mcci-catena / arduino-lmic

LoraWAN-MAC-in-C library, adapted to run under the Arduino environment
https://forum.mcci.io/c/device-software/arduino-lmic/
MIT License
646 stars 212 forks source link

Please expose gwmargin and ngws from MCC_LinkCheckAns #823

Closed BNNorman closed 2 years ago

BNNorman commented 2 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I want to create a node which tells me the margin and number of gateways visible at the location of the node in order to produce a tool for identifying a good inner-city location for installing air-quality sensors. The number of gateways indicates the probable connection reliability of a site whilst the margin indicates the chances of successful signal decoding. I can get SNR and RSSI but gateway count is more important to me.

The MCMD_LinkCheckAns has the gwmargin and ngws return values commented out in lmic.c. I.e. the return values are ignored.

Describe the solution you'd like A clear and concise description of what you want to happen.

Provide two public methods to return gwmargin and ngws. E.g. int getGwmargin() and int getNgws()

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

I can modify my copy of the lmic.c and lmic.h source code to expose these values myself but, in platformio, when I choose different target devices I get multiple copies of this library in libdeps and would have to hand edit each one to expose gwmargin and ngws. (although I could just copy the changed files).

If this library is updated and silently updates the libdeps in platformio I will lose any local changes made.

Additional context Add any other context or screenshots about the feature request here.

None

BNNorman commented 2 years ago

Closed in favour of #825