AU915 netjoin looks suspicious.

mcci-catena / arduino-lorawan

User-friendly library for using arduino-lmic with The Things Network and other LoRaWAN® networks

MIT License

275 stars 54 forks source link

AU915 netjoin looks suspicious. #131

Closed terrillmoore closed 4 years ago

terrillmoore commented 4 years ago

https://github.com/mcci-catena/arduino-lorawan/blob/3c82a75efb622ee303ece9c89c850d659eaf851e/src/lib/ttn_au921_netjoin.cpp#L78-L79

The comment is certainly wrong, but setting the RX2 datarate manually also looks wrong. Review the regional spec and TTN plans; either remove this, or else condition on ABP (TTN sends the right info for OTAA).