search

mcci-catena / arduino-lorawan

User-friendly library for using arduino-lmic with The Things Network and other LoRaWAN® networks
MIT License
274 stars 54 forks source link

Add return statement on Arduino_LoRaWAN::setFrequency #204

Closed olicooper closed 1 year ago

olicooper commented 1 year ago

Missing return statement on Arduino_LoRaWAN::setFrequency - causes compile errors. Could be related to an earlier issue I raised? https://github.com/mcci-catena/arduino-lorawan/issues/181

vkynchev commented 1 year ago

I can confirm that adding return true; at the end of setFrequency method resolved the core panic on esp32...

supcik commented 1 year ago

I also stumbled on this error

klauweg commented 1 year ago

Since i'm new to esp32/arduino/lorawan/c++ this cost me hours until i found this pull request :-). Why can't it be merged with master soon?

terrillmoore commented 1 year ago

Thanks!