search

mcci-catena / arduino-lorawan

User-friendly library for using arduino-lmic with The Things Network and other LoRaWAN® networks
MIT License
289 stars 55 forks source link

Handle zero-length downlink in Arduino_LoRaWAN::NetRxComplete #50

Closed terrillmoore closed 6 years ago

terrillmoore commented 6 years ago

When reviewing arduino-lmic docs, discovered that the proper form for checking for RX is:

if (LMIC.dataLen != 0 || LMIC.dataBeg != 0)

Right now we only have

if (LMIC.dataLen != 0)

which means that zero-length downlinks are not indicated to the client.

terrillmoore commented 6 years ago

Labeled as a bug because I didn't intend to suppress zero-length downlinks.