mcci-catena / arduino-lorawan

User-friendly library for using arduino-lmic with The Things Network and other LoRaWAN® networks
MIT License
284 stars 54 forks source link

Fix warnings from platformio #72

Closed terrillmoore closed 5 years ago

terrillmoore commented 5 years ago

Platformio compiles complain about the following:

.piolibdeps/MCCI Arduino LoRaWAN Library/src/Arduino_LoRaWAN.h:306:78: warning: no return statement in function returning non-void [-Wreturn-type]
bool begin(const Arduino_LMIC::HalPinmap_t &pinmap) { this->begin(&pinmap); };

and

.piolibdeps/MCCI Arduino LoRaWAN Library/src/Arduino_LoRaWAN.h:143:31: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
for (auto i = 0; i < nCh / 8; ++i)

The changes are easy enough; change to auto i=0u in the second case and add missing return in first case. But there may be other warnings lurking in the forest....