Closed terrillmoore closed 5 years ago
As part of https://github.com/mcci-catena/arduino-lmic/commit/53c27e4534fbdc0a16f90019527e6242a14bfd13, we added the following:
// compute exit status if (ev == EV_TXCANCELED) { // canceled: unsuccessful. fSuccess = 0; } else if (/* ev == EV_TXCOMPLETE && */ LMIC.pendTxConf) { fSuccess = (LMIC.txrxFlags & TXRX_ACK) != 0; } else { // unconfirmed uplinks are successful if they were sent. fSuccess = 1; }
Arduino_LoRaWAN doesn't have those checks (for confirmed/unconfirmed uplink, and cancel) and it should.
As part of https://github.com/mcci-catena/arduino-lmic/commit/53c27e4534fbdc0a16f90019527e6242a14bfd13, we added the following:
Arduino_LoRaWAN doesn't have those checks (for confirmed/unconfirmed uplink, and cancel) and it should.