search

mcci-catena / ibm-lmic

The IBM Zurich LMiC codebase
http://www.research.ibm.com/labs/zurich/ics/lrsc/lmic.html
BSD 3-Clause "New" or "Revised" License
49 stars 30 forks source link

Bug fix setting RegPaConfig for SX1276 #17

Open cyberman54 opened 6 years ago

cyberman54 commented 6 years ago

Original code sets PA-output to PA_BOOST pin, but should set to RFO pin.

terrillmoore commented 6 years ago

Thanks, I’m on my way back to NYC from Amsterdam, I’ll try to review this tomorrow. Much appreciated!

From: Verkehrsrot [mailto:notifications@github.com] Sent: Saturday, February 3, 2018 18:34 To: mcci-catena/ibm-lmic ibm-lmic@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [mcci-catena/ibm-lmic] Bug fix setting RegPaConfig for SX1276 (#17)

Original code sets PA-output to PA_BOOST pin, but should set to RFO pin.

You can view, comment on, or merge this pull request online at:

https://github.com/mcci-catena/ibm-lmic/pull/17

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mcci-catena/ibm-lmic/pull/17 , or mute the thread https://github.com/notifications/unsubscribe-auth/ASb_72-5OpWOlzPMpUAHguq0MzsMMtYcks5tRJhzgaJpZM4R4QCR .

terrillmoore commented 5 years ago

Don't know why I've let this sit so long. It probably would be helpful for people if we were to backport some of the arduino-lmic fixes to this. But anyway, I've got a new search that will remind me of this, so I should get to this shortly.