mcclown / home-assistant-custom-components

Custom components for Home-Assistant
Apache License 2.0
18 stars 7 forks source link

Enable HACS for uHoo custom component #8

Open ehn opened 4 years ago

ehn commented 4 years ago

This PR makes it possible to install the uHoo custom component using HACS.

You probably don't want to accept this PR as it is because it removes the AquaIllumination and Seneye components. For HACS, you need one repo per component.

andrewleech commented 3 years ago

Hi @ehn for this change, I find HACS really useful to install custom components as well!

As others have noted, the pyuhooair package which uses the enterprise api does not work for regular users :-(

However there's now a new package pyuhoo which uses a consumer api, thanks to @csacca

I've ported this HACS version of uHoo component over to the new package, seems to work great, if you're interested you can find it here: https://github.com/andrewleech/ha_uhoo

csacca commented 3 years ago

FYSA, I also have a HACS repo for a home assistant uHoo component based on pyuhoo located here: https://github.com/csacca/uhoo-homeassistant

andrewleech commented 3 years ago

Ah well don't I feel silly now, doubling up on effort like that. I'm disappointed I didn't find that first, thanks for letting us know @csacca ! I'll definitely take a look