search

mccolljr / segvec

SegVec data structure for rust. Similar to Vec, but allocates memory in chunks of increasing size.
MIT License
35 stars 5 forks source link

make miri happy #36

Closed vxpm closed 1 year ago

vxpm commented 1 year ago

fixes #29 and others

it would be good to add // SAFETY: ... comments - i'll probably add some in a few hours.

mccolljr commented 1 year ago

// SAFETY comments would be nice, but I also think that your changes leave it fairly obvious why each new unsafe usage is safe.

Do you have any interest in modifying the CI code to run the tests under miri in addition to the current runs? Totally fine if not, I can try to get this enabled later this week, but since you're already here I thought I would ask.

vxpm commented 1 year ago

sure! i'll do it together with the safety comments in a few hours.